Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve buttons visibility #536

Merged
merged 15 commits into from
Nov 10, 2023

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Nov 9, 2023

Pull Request

This PR improves visibility of buttons in "Create New Asset" Dialog especially when using yellow theming.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Linked Issue(s)

Use keywords to automate: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

  • fixes # (issue)
  • closes # (issue)
  • ...

PR is blocked by

  • blocked by # (issue)

Checklist

  • I have formatted the title correctly and precisely
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and public classes/methods
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings (performed checkstyle check locally)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have added/updated copyright headers

@illfixit illfixit self-assigned this Nov 9, 2023
@illfixit illfixit linked an issue Nov 9, 2023 that may be closed by this pull request
@illfixit illfixit marked this pull request as ready for review November 9, 2023 12:16
@illfixit illfixit enabled auto-merge (squash) November 9, 2023 12:23
richardtreier
richardtreier previously approved these changes Nov 9, 2023
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illfixit illfixit merged commit b3d4092 into main Nov 10, 2023
11 checks passed
@illfixit illfixit deleted the 531-fix-button-colors-in-the-mds-variant branch November 10, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Button Colors in the MDS Variant
2 participants